gadget: inject default netplan configuration in gadget configuration - #16631
Open
valentindavid wants to merge 1 commit into
Open
gadget: inject default netplan configuration in gadget configuration#16631valentindavid wants to merge 1 commit into
valentindavid wants to merge 1 commit into
Conversation
valentindavid
added
the
Run nested
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #16631 +/- ##
==========================================
+ Coverage 79.04% 79.11% +0.06%
==========================================
Files 1375 1364 -11
Lines 191012 190800 -212
Branches 2465 2465
==========================================
- Hits 150981 150942 -39
+ Misses 30924 30768 -156
+ Partials 9107 9090 -17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Fri May 8 08:03:47 UTC 2026 Failures:Preparing:
Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
valentindavid
marked this pull request as draft
February 20, 2026 15:50
valentindavid
force-pushed
the
valentindavid/inject-netplan-default-config
branch
2 times, most recently
from
March 16, 2026 16:15
5490f5c to
1079406
Compare
valentindavid
force-pushed
the
valentindavid/inject-netplan-default-config
branch
from
March 27, 2026 13:20
1079406 to
02cb57c
Compare
valentindavid
marked this pull request as ready for review
March 27, 2026 13:21
alfonsosanchezbeato
approved these changes
Apr 6, 2026
alfonsosanchezbeato
left a comment
alfonsosanchezbeato
left a comment
Contributor
There was a problem hiding this comment.
LGTM - but this would need a spread test, could be a follow-up
Member
Author
Yeah. I can try to do that in this PR. |
valentindavid
force-pushed
the
valentindavid/inject-netplan-default-config
branch
2 times, most recently
from
April 15, 2026 09:54
1c0f237 to
9fc3eb0
Compare
Member
Author
We cannot test on non nested, because we need to be able to have different netplan configurations for tests, which is not possible. We cannot test with nested tests without disabling cloud-init and using user assertions. I would prefer to wait for changing nested tests to not use cloud-init in general than making a complex test right now. I will open a jira card for adding the test. |
valentindavid
force-pushed
the
valentindavid/inject-netplan-default-config
branch
from
April 24, 2026 10:52
9fc3eb0 to
1641b95
Compare
The plan is to remove the default gadget configuration from core26. But to be able to make netplan work on gadget missing netplan configuration, we should inject the old configuration.
valentindavid
force-pushed
the
valentindavid/inject-netplan-default-config
branch
from
May 5, 2026 09:09
1641b95 to
78bcf32
Compare
github-actions
Bot
added
the
Auto rerun spread
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plan is to remove the default gadget configuration from core26. But to be able to make netplan work on gadget missing netplan configuration, we should inject the old configuration.